Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing state reset on NoBlending (#9564) #9839

Merged
merged 1 commit into from
Oct 11, 2016
Merged

Fix missing state reset on NoBlending (#9564) #9839

merged 1 commit into from
Oct 11, 2016

Conversation

fallenoak
Copy link
Contributor

@fallenoak fallenoak commented Oct 10, 2016 •
edited by mrdoob
Loading

Per @Rantanen's issue, not all state is cleared when switching between materials with THREE.NoBlending and THREE.CustomBlending.

This PR fixes the issue for me. Thus far, I haven't come across any side effects.

Fixes #9564

@fallenoak
Copy link
Contributor Author

Would a better approach perhaps be to simply remove the early return?

@mrdoob
Copy link
Owner

mrdoob commented Oct 10, 2016 •
edited
Loading

Yeah, I think removing the early return is the correct fix. I'll ammend post-merge.

@mkeblx mkeblx mentioned this pull request Oct 10, 2016
Closed
9 tasks
@mrdoob mrdoob merged commit ea22d56 into mrdoob:dev Oct 11, 2016
@mrdoob
Copy link
Owner

mrdoob commented Oct 11, 2016

Thanks!

mrdoob added a commit that referenced this pull request Oct 11, 2016
@mrdoob
WebGLState: Simpler fix for NoBlending issue. See #9839
973380c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom blending states reset between rendered frames
2 participants
@fallenoak @mrdoob